No description
5bcf58c7d6
As can be seen in do_property_scale()'s definition in
flightgear/src/Main/fg_commands.cxx, property-scale rightfully uses a
default factor of 1.0. However, if a joystick axis' property-scale
binding has no 'factor' node defined, and one opens the joystick
configuration dialog, then PropertyScaleAxis.parse() creates an empty
'factor' node that implicitely gets a value of 0. This method is called
by joystick.readConfig() when the joystick-config dialog is opened. This
has the effect of rendering the corresponding joystick axis inoperant.
How to reproduce the bug:
- take a joystick such as the SAITEK CYBORG 3D USB, with its default
binding file from
fgdata/Input/Joysticks/Saitek/Cyborg-Gold-3d-USB.xml (this file uses
property-scale for the aileron, with no explicitely defined factor);
- start FlightGear; move the joystick left or right while looking at
the plane wings -> the ailerons move, it works fine;
- now, open the joystick-config dialog and do the same test -> the
ailerons don't move anymore and the 'Aileron' value at the bottom of
the dialog stays at 0 (0.0 or -0.0...). Just opening the dialog to
test the joystick has "corrupted" its setup! This is very confusing
for users.
This fix corrects the problem by avoiding the apparently unneeded
creation of an empty 'factor' node when there is none inside the
<binding>. An alternative would be to create a 'factor' node with value
1.0. In any case, if someone later expands the joystick-config dialog to
allow modification of property-scale's factor, he should make sure to
use a default value of 1.0!
|
||
|---|---|---|
| AI | ||
| Aircraft | ||
| Aircraft-uiuc | ||
| Airports | ||
| Astro | ||
| ATC | ||
| Docs | ||
| Effects | ||
| Environment | ||
| Fonts | ||
| Geodata | ||
| gui | ||
| HLA | ||
| Huds | ||
| Input | ||
| Lighting | ||
| Materials | ||
| Models | ||
| MP | ||
| Nasal | ||
| Navaids | ||
| Phi | ||
| Protocol | ||
| Scenery | ||
| Shaders | ||
| Sounds | ||
| Textures | ||
| Timezone | ||
| Translations | ||
| .gitignore | ||
| AtlasPalette | ||
| AUTHORS | ||
| ChangeLog | ||
| COPYING | ||
| httpd-settings.xml | ||
| joysticks.xml | ||
| keyboard.xml | ||
| mice.xml | ||
| NEWS | ||
| options.xml | ||
| preferences.xml | ||
| README | ||
| README-textures-ng | ||
| runfgfs.bat | ||
| Thanks | ||
| version | ||
Welcome to the FlightGear Flight Simulator project. =================================================== The primary web page for this project is: http://www.flightgear.org For basic installation instructions see the "INSTALL" file. Before you can run FlightGear you will also need to download and install the "base" package which is a collection of textures, sounds, sample scenery, and other data files needed by the sim. For additional install help for specific platforms please browse the "docs-mini/" subdirectory. More complete documentation is available from our web page as a separate distribution. Please take a look at the "Thanks" file for a list of people who have contributed to this project. If you have contributed something but don't find your name in this file. Please send a polite reminder to http://www.flightgear.org/~curt For a summary of changes/additions by version see the "NEWS" file. This project is GPL'd. For complete details on our licensing please see the "COPYING" file. For information on available mailing lists, mailing list archives, and other available source code and documentation, please visit our web site. FlightGear is a product of the collaboration of large international group of volunteers. FlightGear is a work in progress. FlightGear comes with no warranty. We hope you enjoy FlightGear and/or find it of some value!