Scott Giese
df67cc2bd9
Python: best practices
...
Check eq/ne
Anticipate file issues
Ensure file closure
2020-08-29 12:07:15 -05:00
Scott Giese
7b914bc5fb
Removed unreachable code
2020-08-29 11:20:40 -05:00
Scott Giese
a87d9ca76f
BezierNode: logic error in initialization
2020-08-29 11:03:31 -05:00
Scott Giese
532d879f72
Dead code removal
2020-08-29 11:00:55 -05:00
Scott Giese
5a29e7aade
Resolve warning: Double Delete
2020-08-29 10:47:12 -05:00
Scott Giese
e079f0d1eb
Resolve warnings: comparison between unsigned and signed types
2020-08-29 10:15:02 -05:00
Scott Giese
8cede3f065
Resolve Deprecation Warnings
2020-08-29 10:12:35 -05:00
James Turner
740193a378
CMake: different fix for ALIAS issues with 3.10
...
ALIAS is not really functional in 3.10, so use a variable to approximate
the same behaviour. Not elegant but it seems to work.
2020-08-27 22:33:08 +01:00
James Turner
37d820120d
Unit-testing: tests for Nasal SGCommand API
...
Test adding/removing/invoking commands, and error handles when
duplicate adding and removing a command name.
2020-08-26 17:20:58 +01:00
James Turner
66f938be8e
Sentry: fix naming clash.
2020-08-26 15:29:55 +01:00
James Turner
a882b75c9b
Sentry: fix fatal-error event type.
2020-08-26 13:57:44 +01:00
James Turner
5dbab6e90e
CMake: overhaul how we find 3rd-party files
...
Handle the standard windows-3rd-party setup (used by fgmeta) with no
extra options, and also handle the slightly odd setup we use on Jenkins.
Try to tolerate all permutations of setting MSVC_3RDPARTY_ROOT to
different places in the hierarchy.
We no longer try to guess Boost_INCLUDEDIR by looking at parent dirs of
MSVC_3RDPARTY_ROOT, since this seemed kind of bad to me. Let’s try
it and see.
2020-08-26 13:57:24 +01:00
Automatic Release Builder
9d775cdfe7
Fix duplicate init of Sentry on reset
2020-08-26 09:52:16 +01:00
Automatic Release Builder
73b4c3839d
Sentry: more breadcrumbs
2020-08-26 09:52:09 +01:00
Automatic Release Builder
d9b7435dab
Sentry logging of exceptions, fatal errors
2020-08-26 09:52:02 +01:00
Automatic Release Builder
bade1ec4c6
Attempt to fix ref-ptr crash on exit
...
Fixing Sentry issue FLIGHTGEAR-9
2020-08-26 09:51:55 +01:00
James Turner
06b026a218
GUI/knob animation: fire release binding over PUI
...
Fire the release bindings for active pick callbacks, even for a ‘handled’
mouse release. This means knobs, etc will fire their release binding
if the mouse is over a PUI dialog.
https://sourceforge.net/p/flightgear/codetickets/2347/
2020-08-25 20:48:29 +01:00
James Turner
8a1109160b
Fix Nasal ‘removecommand’ so it actually works.
2020-08-25 19:23:43 +01:00
James Turner
55e971f808
Asan: fix an Flite error found by Michael Danilov
...
We have been missing a build flag for FLite, to specify the alignment
of some unions. ASan detected this as access outwith allocated memory.
Fix is to pass a defining indicating we’re on a 64-bit system.
See discussion here:
https://sourceforge.net/p/flightgear/codetickets/2361/
2020-08-24 17:40:35 +01:00
James Turner
cf424e4344
Rename buildId header file
...
Avoid the very common name ‘build.h’ in favour of something clearer
and FlightGear specific.
2020-08-24 15:05:16 +01:00
James Turner
178d1beb80
Cmake: Remove version.h machinery
...
Merge this file into config.h, this means we can save an include path
everywhere.
2020-08-24 15:04:24 +01:00
James Turner
6dfbda9bd1
Cmake: ifx abuse of OBJECT libraries
...
Use STATIC intermeidate libs for these pieces, to keep older CMake
versions happy.
2020-08-24 13:19:57 +01:00
James Turner
11932bac4e
Trying to fix EnvironmentManager shutdown crash.
...
Not sure this will fix it, but it’s the only scenario I can spot so far,
so let’s try anwyay.
Reported at Sentry as: FLIGHTGEAR-8
2020-08-24 10:25:09 +01:00
James Turner
4fe8a118cc
Traffic: Improve iterator robustness
...
Attempting to fix Sentry crash FLIGHTGEAR-B, crash on shutdown. Not
sure this is quite right, but the logic is clearer and we handle
invalid iterators better.
2020-08-24 10:23:50 +01:00
Erik Hofman
c6182af080
Consistent naming
2020-08-24 11:00:05 +02:00
Erik Hofman
49b13372f4
Merge branch 'next' of ssh://git.code.sf.net/p/flightgear/flightgear into next
2020-08-24 08:17:13 +02:00
James Turner
a82a13b70c
Cmake: fix compat with CMake 3.10
...
Thankfully StackOverflow had an evil solution to this missing feature
in 3.10.
2020-08-23 22:25:03 +01:00
James Turner
95fd692af1
CMake: move install() rule for compatability
...
Older CMake versions can’t install(TARGET…) from a different directory.
2020-08-23 21:50:36 +01:00
James Turner
476b9eb3d1
Ensure OSG headers are founding building the UI
2020-08-23 21:10:56 +01:00
Erik Hofman
be1764a995
XMerge branch 'next' of ssh://git.code.sf.net/p/flightgear/flightgear into next
2020-08-23 19:22:47 +02:00
Erik Hofman
00c32f5408
Display that AeonWave is being found, even when cached
2020-08-23 19:22:25 +02:00
James Turner
fef50310bf
Cmake: fix some issues Scott spotted.
2020-08-23 18:15:07 +01:00
James Turner
87a7221051
Linux Cmake fixes
2020-08-23 11:31:37 +01:00
James Turner
f7dc02d009
Fix Swift build with CMake
2020-08-23 11:31:37 +01:00
James Turner
e4e2b34a4c
FGCom OpenAL CMake fixes
...
Ensure we detect OpenAL the way IAXClient expects, and set it up as
a dependency of IAXClient, not FGCom.
2020-08-23 11:31:37 +01:00
James Turner
218df89b29
Embedded resources: better cmake command
...
Use add_custom_command and an intermediate OBJECT library to avoid
rerunning fgrcc unless the XML input file has actually changed.
2020-08-23 11:31:37 +01:00
James Turner
eb55f25997
Newer FindGit
2020-08-23 11:31:37 +01:00
James Turner
47ff3e9f67
Improve CMake strucutre
2020-08-23 11:31:37 +01:00
James Turner
5820619575
Move ENABLE_ASAN check to global scope
...
Allows ASan with GCC.
2020-08-23 11:30:21 +01:00
Scott Giese
63d3dd4cbd
REVIEW: Memory Leak - FLITEVoiceSynthesizer ctor
...
1,696 bytes in 4 blocks are definitely lost in loss record 6,145 of 6,440
2020-08-23 00:21:11 -05:00
Scott Giese
0ce2fdf190
REVIEW: Memory Leak - PositionedOctree.cxx
...
1,728 bytes in 36 blocks are still reachable
1,280 bytes in 8 blocks are still reachable
480 bytes in 3 blocks are still reachable
2020-08-23 00:15:42 -05:00
Scott Giese
dc1519bfe8
REVIEW: Memory Leak - screensaver_control
...
2,056 bytes in 1 blocks are still reachable
352 bytes in 1 blocks are indirectly lost
320 bytes in 1 blocks are still reachable
2020-08-22 22:59:33 -05:00
Scott Giese
f84a522f12
REVIEW: Memory Leak - FGPUIMenuBar::add_enabled_listener()
...
3,920 (3,136 direct, 784 indirect) bytes in 98 blocks are definitely lost
2020-08-22 22:22:47 -05:00
Scott Giese
61f86b7dda
Merge branch 'next' of https://git.code.sf.net/p/flightgear/flightgear into next
2020-08-22 21:49:10 -05:00
Scott Giese
9d6239031f
REVIEW: Memory Leak - wxRadarBg::init()
...
4,096 bytes in 1 blocks are indirectly lost
2020-08-22 21:48:52 -05:00
Scott Giese
cbe13026c5
REVIEW: Memory Leak - wxRadarBg::init()
...
4,096 bytes in 1 blocks are indirectly lost
2020-08-22 21:46:40 -05:00
Scott Giese
6c14eaa6e8
REVIEW: Memory Leak - FGLinuxEventInput::postinit()
...
4,995 (40 direct, 4,955 indirect) bytes in 1 blocks are definitely lost
2020-08-22 21:26:03 -05:00
Scott Giese
8e9e16bac6
REVIEW: Memory Leak - Branch::childAtIndex
...
9,152 bytes in 52 blocks are still reachable
2020-08-22 18:01:15 -05:00
Scott Giese
f21eb3a484
REVIEW: Memory Leak - Options ctor
...
15,768 bytes in 219 blocks are still reachable
2020-08-22 17:23:55 -05:00
Scott Giese
14b28d4f72
REVIEW: Memory Leak - FGLinuxEventInput::posinit()
...
55,004 (40 direct, 54,964 indirect) bytes in 1 blocks are definitely lost
2020-08-22 17:05:35 -05:00