Patch from Julian Foad:
Use getDisplayName instead of duplicated code: gives a better decision on whether to display the index. Replace unnecessary node lookups by name with direct access: tidier and more efficient. E.g. "getValueTypeString (node->getNode(name.c_str()))" -> "getValueTypeString (child)".
This commit is contained in:
parent
7599f0ec8c
commit
0ba90f4d2b
1 changed files with 3 additions and 12 deletions
|
@ -203,15 +203,7 @@ PropsChannel::foundTerminator()
|
|||
for (int i = 0; i < dir->nChildren(); i++)
|
||||
{
|
||||
SGPropertyNode * child = dir->getChild(i);
|
||||
string name = child->getName();
|
||||
string line = name;
|
||||
|
||||
if (dir->getChild( name.c_str(), 1 ))
|
||||
{
|
||||
char buf[16];
|
||||
sprintf(buf, "[%d]", child->getIndex());
|
||||
line += buf;
|
||||
}
|
||||
string line = child->getDisplayName(true);
|
||||
|
||||
if ( child->nChildren() > 0 )
|
||||
{
|
||||
|
@ -221,10 +213,9 @@ PropsChannel::foundTerminator()
|
|||
{
|
||||
if (mode == PROMPT)
|
||||
{
|
||||
string value = dir->getStringValue( name.c_str(), "" );
|
||||
string value = child->getStringValue();
|
||||
line += " =\t'" + value + "'\t(";
|
||||
line += getValueTypeString(
|
||||
dir->getNode( name.c_str() ) );
|
||||
line += getValueTypeString( child );
|
||||
line += ")";
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Add table
Reference in a new issue