James Turner
f5b5828bd0
AIFlightPlan: add test for XML parsing
...
This meant some slight refactoring to expose some easier APIs for
testing, but the normal methods should be unaffected.
2020-09-05 10:44:43 +01:00
James Turner
3a3ff07883
Start testing FGAIFlightPlan
2020-09-05 10:44:43 +01:00
Erik Hofman
0272a4fa3f
Merge branch 'next' of ssh://git.code.sf.net/p/flightgear/flightgear into next
2020-09-04 16:03:39 +02:00
Erik Hofman
a95aaab0f4
use in-place declarations and clean up the code a bit
2020-09-04 16:03:04 +02:00
James Turner
2147eb8da9
Missed fixes from previous Yasim commit.
2020-09-04 13:05:11 +01:00
James Turner
d2fb16e071
Fix mismatched new/strdup/delete[] froub by ASan
...
See: https://sourceforge.net/p/flightgear/codetickets/2367/ for the
issue. Switch to using std::string instead of char*, and hence any
need to manually free the memory.
2020-09-04 12:41:56 +01:00
James Turner
4402d7b81d
NavCache: only remove if the file exists.
...
Otherwise we block trying to re-create the cache, which is dumb. This
showed up as Sentry issue:
https://sentry.io/organizations/flightgear/issues/1875854826
Will back-port to 2020.2 once verified.
2020-09-04 12:29:45 +01:00
James Turner
1fd5502e9b
Nasal removecommand: use a return value
...
Change removecommand() to indicate success or failure via a return
value: 1 for success, 0 for failure.
2020-09-04 10:56:41 +01:00
Erik Hofman
c6cb845f90
Merge branch 'next' of ssh://git.code.sf.net/p/flightgear/flightgear into next
2020-09-04 11:45:33 +02:00
Erik Hofman
6bd87586b0
Fix stability: CL and CD must be negative
2020-09-04 11:44:37 +02:00
Erik Hofman
e8fe8345bf
Start using or own types for vectors and matrices for sharter and more readable code. Fix some sign issues
2020-09-04 10:58:18 +02:00
James Turner
9090d91be3
Fix a missed pu.h rename.
2020-09-03 20:25:14 +01:00
James Turner
22bad9db33
Fix for CMake/system libSGM issue: consistent path
...
Our copy of libGSM, and a system-wide version have different include
suffixes, so adjust the FindGsm.cmake so that the returned include-path
is consistent with our internal version.
See discussion in:https://sourceforge.net/p/flightgear/codetickets/2368/
2020-09-03 19:18:57 +01:00
James Turner
1f6b43c38f
More AI tests
2020-09-03 17:51:40 +01:00
James Turner
61c6cfb050
AIAircraft: fix type of non-Swift aircraft
2020-09-03 17:51:40 +01:00
James Turner
d1fc4b58cb
Start creating tests of AIModel code
...
First test just creates the manager, and ensures the user aircraft
updates in sync with the real aircraft.
2020-09-03 17:51:40 +01:00
Erik Hofman
ce1e85f656
Get the AISim FDM in a semi-flyable state
2020-09-03 14:39:38 +02:00
Erik Hofman
bdc66d5535
Rename our own version of pu.h to FlightGear_pu.h per James advice. Remove inclusion of pu.h where it isn't requirted.
2020-09-03 12:56:01 +02:00
Erik Hofman
0451816a82
Add our own version of pu.h and use it to prevent bug #2362 on all systems. This can be done since pu.h is to be considered in code freeze forever anyhow.
2020-09-01 10:12:42 +02:00
Scott Giese
ad2bf3cd09
Revert "Resolve Deprecation Warnings"
...
This reverts commit 8cede3f065
.
2020-08-30 17:58:36 -05:00
Scott Giese
df67cc2bd9
Python: best practices
...
Check eq/ne
Anticipate file issues
Ensure file closure
2020-08-29 12:07:15 -05:00
Scott Giese
7b914bc5fb
Removed unreachable code
2020-08-29 11:20:40 -05:00
Scott Giese
a87d9ca76f
BezierNode: logic error in initialization
2020-08-29 11:03:31 -05:00
Scott Giese
532d879f72
Dead code removal
2020-08-29 11:00:55 -05:00
Scott Giese
5a29e7aade
Resolve warning: Double Delete
2020-08-29 10:47:12 -05:00
Scott Giese
e079f0d1eb
Resolve warnings: comparison between unsigned and signed types
2020-08-29 10:15:02 -05:00
Scott Giese
8cede3f065
Resolve Deprecation Warnings
2020-08-29 10:12:35 -05:00
James Turner
740193a378
CMake: different fix for ALIAS issues with 3.10
...
ALIAS is not really functional in 3.10, so use a variable to approximate
the same behaviour. Not elegant but it seems to work.
2020-08-27 22:33:08 +01:00
James Turner
37d820120d
Unit-testing: tests for Nasal SGCommand API
...
Test adding/removing/invoking commands, and error handles when
duplicate adding and removing a command name.
2020-08-26 17:20:58 +01:00
James Turner
66f938be8e
Sentry: fix naming clash.
2020-08-26 15:29:55 +01:00
James Turner
a882b75c9b
Sentry: fix fatal-error event type.
2020-08-26 13:57:44 +01:00
James Turner
5dbab6e90e
CMake: overhaul how we find 3rd-party files
...
Handle the standard windows-3rd-party setup (used by fgmeta) with no
extra options, and also handle the slightly odd setup we use on Jenkins.
Try to tolerate all permutations of setting MSVC_3RDPARTY_ROOT to
different places in the hierarchy.
We no longer try to guess Boost_INCLUDEDIR by looking at parent dirs of
MSVC_3RDPARTY_ROOT, since this seemed kind of bad to me. Let’s try
it and see.
2020-08-26 13:57:24 +01:00
Automatic Release Builder
9d775cdfe7
Fix duplicate init of Sentry on reset
2020-08-26 09:52:16 +01:00
Automatic Release Builder
73b4c3839d
Sentry: more breadcrumbs
2020-08-26 09:52:09 +01:00
Automatic Release Builder
d9b7435dab
Sentry logging of exceptions, fatal errors
2020-08-26 09:52:02 +01:00
Automatic Release Builder
bade1ec4c6
Attempt to fix ref-ptr crash on exit
...
Fixing Sentry issue FLIGHTGEAR-9
2020-08-26 09:51:55 +01:00
James Turner
06b026a218
GUI/knob animation: fire release binding over PUI
...
Fire the release bindings for active pick callbacks, even for a ‘handled’
mouse release. This means knobs, etc will fire their release binding
if the mouse is over a PUI dialog.
https://sourceforge.net/p/flightgear/codetickets/2347/
2020-08-25 20:48:29 +01:00
James Turner
8a1109160b
Fix Nasal ‘removecommand’ so it actually works.
2020-08-25 19:23:43 +01:00
James Turner
55e971f808
Asan: fix an Flite error found by Michael Danilov
...
We have been missing a build flag for FLite, to specify the alignment
of some unions. ASan detected this as access outwith allocated memory.
Fix is to pass a defining indicating we’re on a 64-bit system.
See discussion here:
https://sourceforge.net/p/flightgear/codetickets/2361/
2020-08-24 17:40:35 +01:00
James Turner
cf424e4344
Rename buildId header file
...
Avoid the very common name ‘build.h’ in favour of something clearer
and FlightGear specific.
2020-08-24 15:05:16 +01:00
James Turner
178d1beb80
Cmake: Remove version.h machinery
...
Merge this file into config.h, this means we can save an include path
everywhere.
2020-08-24 15:04:24 +01:00
James Turner
6dfbda9bd1
Cmake: ifx abuse of OBJECT libraries
...
Use STATIC intermeidate libs for these pieces, to keep older CMake
versions happy.
2020-08-24 13:19:57 +01:00
James Turner
11932bac4e
Trying to fix EnvironmentManager shutdown crash.
...
Not sure this will fix it, but it’s the only scenario I can spot so far,
so let’s try anwyay.
Reported at Sentry as: FLIGHTGEAR-8
2020-08-24 10:25:09 +01:00
James Turner
4fe8a118cc
Traffic: Improve iterator robustness
...
Attempting to fix Sentry crash FLIGHTGEAR-B, crash on shutdown. Not
sure this is quite right, but the logic is clearer and we handle
invalid iterators better.
2020-08-24 10:23:50 +01:00
Erik Hofman
c6182af080
Consistent naming
2020-08-24 11:00:05 +02:00
Erik Hofman
49b13372f4
Merge branch 'next' of ssh://git.code.sf.net/p/flightgear/flightgear into next
2020-08-24 08:17:13 +02:00
James Turner
a82a13b70c
Cmake: fix compat with CMake 3.10
...
Thankfully StackOverflow had an evil solution to this missing feature
in 3.10.
2020-08-23 22:25:03 +01:00
James Turner
95fd692af1
CMake: move install() rule for compatability
...
Older CMake versions can’t install(TARGET…) from a different directory.
2020-08-23 21:50:36 +01:00
James Turner
476b9eb3d1
Ensure OSG headers are founding building the UI
2020-08-23 21:10:56 +01:00
Erik Hofman
be1764a995
XMerge branch 'next' of ssh://git.code.sf.net/p/flightgear/flightgear into next
2020-08-23 19:22:47 +02:00