Add a notification when catalog refresh fails

src/GUI/LauncherPackageDelegate.cxx

@@ -43,12 +43,26 @@ LauncherPackageDelegate::~LauncherPackageDelegate()
 
 void LauncherPackageDelegate::catalogRefreshed(simgear::pkg::CatalogRef aCatalog, simgear::pkg::Delegate::StatusCode aReason)
 {
+    auto nc = LauncherNotificationsController::instance();
+
+    if (aCatalog) {
+        // if catalog download / write to disk failed, show a notification
+        if ((aReason == Delegate::FAIL_EXTRACT) ||
+            (aReason == Delegate::FAIL_DOWNLOAD) ||
+            (aReason == Delegate::FAIL_FILESYSTEM) ||
+            (aReason == Delegate::FAIL_VALIDATION)) {
+            QJSValue args = nc->jsEngine()->newObject();
+            args.setProperty("catalogUri", QString::fromStdString(aCatalog->url()));
+            nc->postNotification("catalog-refresh-failed",
+                                 QUrl{"qrc:///qml/CatalogRefreshFailedNotification.qml"},
+                                 args);
+        }
+    }
+
     if ((aReason != Delegate::STATUS_REFRESHED) || !aCatalog) {
         return;
     }
 
-    auto nc = LauncherNotificationsController::instance();
-
     if (aCatalog->migratedFrom() != simgear::pkg::CatalogRef{}) {
         QJSValue args = nc->jsEngine()->newObject();
 

src/GUI/qml/CatalogRefreshFailedNotification.qml

@@ -0,0 +1,14 @@
+import QtQuick 2.4
+import "."
+
+Text {
+    signal dismiss();
+
+    readonly property string failUri: _notifications.argsForIndex(model.index).catalogUri
+
+    text: qsTr("The catalog at '%1' failed to download and validate correctly. All aircraft it provides will be unavailable.").arg(failUri)
+
+    wrapMode: Text.WordWrap
+    font.pixelSize: Style.subHeadingFontPixelSize
+    color: "white"
+}

src/GUI/resources.qrc

@@ -148,6 +148,7 @@
         <file>qml/ScrollToBottomHint.qml</file>
         <file>qml/GettingStartedTipLayer.qml</file>
         <file>qml/GettingStartedTipDisplay.qml</file>
+        <file>qml/CatalogRefreshFailedNotification.qml</file>
     </qresource>
     <qresource prefix="/preview">
         <file alias="close-icon">assets/preview-close.png</file>