1
0
Fork 0

Unit tests for initial position (Main/positioninit.cxx)

Various unit tests for
- airports
- runways
- vor
- ndb
- fix
- lat/lon
- carrier
- offsets from the above (except carriers)
This commit is contained in:
Stuart Buchanan 2020-04-12 21:46:50 +01:00
parent 6ab7c08aa5
commit b561cc8fac
2 changed files with 486 additions and 12 deletions

View file

@ -18,17 +18,24 @@
#include "test_posinit.hxx"
#include <thread>
#include <chrono>
#include "test_suite/FGTestApi/testGlobals.hxx"
#include "test_suite/FGTestApi/NavDataCache.hxx"
#include "test_suite/FGTestApi/scene_graph.hxx"
#include <simgear/props/props_io.hxx>
#include <AIModel/AIManager.hxx>
#include "Main/positioninit.hxx"
#include "Main/options.hxx"
#include "Main/globals.hxx"
#include "Main/fg_props.hxx"
#include "Navaids/navlist.hxx"
#include "Airports/airport.hxx"
#include "Airports/groundnetwork.hxx"
using namespace flightgear;
@ -46,6 +53,51 @@ void PosInitTests::tearDown()
FGTestApi::tearDown::shutdownTestGlobals();
}
void PosInitTests::checkAlt(float value)
{
CPPUNIT_ASSERT_DOUBLES_EQUAL_MESSAGE("/position/altitude-ft", value, globals->get_props()->getDoubleValue("/position/altitude-ft"), 10.0);
}
void PosInitTests::checkHeading(float value)
{
CPPUNIT_ASSERT_DOUBLES_EQUAL_MESSAGE("/orientation/heading-deg incorrect", value, globals->get_props()->getDoubleValue("/orientation/heading-deg"), 1.0);
}
void PosInitTests::checkPosition(SGGeod expectedPos, float delta)
{
double dist = SGGeodesy::distanceM(globals->get_aircraft_position(),
expectedPos);
std::cerr << "Position distance " << dist << "\n";
CPPUNIT_ASSERT_MESSAGE("Unexpected Position", dist < delta);
}
void PosInitTests::checkClosestAirport(std::string icao)
{
std::string closest = globals->get_props()->getStringValue("/sim/airport/closest-airport-id");
CPPUNIT_ASSERT_EQUAL_MESSAGE("Closest Airport (/sim/airport/closest-airport-id) Incorrect", icao, closest);
}
void PosInitTests::checkStringProp(std::string property, std::string expected)
{
std::string value = globals->get_props()->getStringValue(property);
CPPUNIT_ASSERT_EQUAL_MESSAGE(property, expected, value);
}
void PosInitTests::checkRunway(std::string expected)
{
checkStringProp("/sim/presets/runway", expected);
}
void PosInitTests::checkOnGround()
{
CPPUNIT_ASSERT_MESSAGE("/sim/presets/onground!=true for ground start", fgGetBool("/sim/presets/onground"));
}
void PosInitTests::checkInAir()
{
CPPUNIT_ASSERT_MESSAGE("/sim/presets/onground != false for in air start", fgGetBool("/sim/presets/onground") == false);
CPPUNIT_ASSERT_MESSAGE("/sim/presets/trim != true for in air start", fgGetBool("/sim/presets/trim") == true);
}
void PosInitTests::testDefaultStartup()
{
@ -70,14 +122,9 @@ void PosInitTests::testDefaultStartup()
readProperties(presets, props);
std::string icao = props->getStringValue("/sim/presets/airport-id");
CPPUNIT_ASSERT(globals->get_props()->getStringValue("/sim/airport/closest-airport-id") == icao);
SGGeod pos = globals->get_aircraft_position();
FGAirportRef defaultAirport = FGAirport::getByIdent(icao);
double dist = SGGeodesy::distanceM(pos, defaultAirport->geod());
CPPUNIT_ASSERT(dist < 10000);
checkClosestAirport(icao);
checkPosition(defaultAirport->geod(), 10000.0);
}
}
@ -95,10 +142,98 @@ void PosInitTests::testAirportOnlyStartup()
CPPUNIT_ASSERT(fgGetBool("/sim/presets/airport-requested"));
initPosition();
CPPUNIT_ASSERT(globals->get_props()->getStringValue("/sim/airport/closest-airport-id") == std::string("EDDF"));
double dist = SGGeodesy::distanceM(globals->get_aircraft_position(),
FGAirport::getByIdent("EDDF")->geod());
CPPUNIT_ASSERT(dist < 10000);
checkClosestAirport(std::string("EDDF"));
checkPosition(FGAirport::getByIdent("EDDF")->geod(), 10000.0);
}
void PosInitTests::testAirportAltitudeOffsetStartup()
{
{
Options* opts = Options::sharedInstance();
opts->setShouldLoadDefaultConfig(false);
const char* args[] = {"dummypath", "--airport=EDDF", "--altitude=1000", "--offset-azimuth=90", "--offset-distance=5", "--heading=45"};
opts->init(6, (char**) args, SGPath());
opts->processOptions();
}
CPPUNIT_ASSERT(fgGetBool("/sim/presets/airport-requested"));
initPosition();
SGGeod expectedPos = SGGeodesy::direct(FGAirport::getByIdent("EDDF")->geod(), 270, 5 * SG_NM_TO_METER);
checkPosition(expectedPos, 5000.0);
checkAlt(1000.0);
checkHeading(45.0);
}
void PosInitTests::testAirportAndRunwayStartup()
{
{
Options* opts = Options::sharedInstance();
opts->setShouldLoadDefaultConfig(false);
const char* args[] = {"dummypath", "--airport=EDDF", "--runway=25C"};
opts->init(3, (char**) args, SGPath());
opts->processOptions();
}
CPPUNIT_ASSERT(fgGetBool("/sim/presets/airport-requested"));
CPPUNIT_ASSERT(fgGetBool("/sim/presets/runway-requested"));
checkRunway(std::string("25C"));
initPosition();
checkClosestAirport(std::string("EDDF"));
checkPosition(FGAirport::getByIdent("EDDF")->geod(), 10000.0);
}
void PosInitTests::testAirportAndParkingStartup()
{
{
Options* opts = Options::sharedInstance();
opts->setShouldLoadDefaultConfig(false);
const char* args[] = {"dummypath", "--airport=EDDF", "--parkpos=V266"};
opts->init(3, (char**) args, SGPath());
opts->processOptions();
}
CPPUNIT_ASSERT(fgGetBool("/sim/presets/airport-requested"));
CPPUNIT_ASSERT(! fgGetBool("/sim/presets/runway-requested"));
checkStringProp("/sim/presets/parkpos", "V266");
initPosition();
SGGeod parkingPosition = SGGeod::fromDeg(8.525026, 50.037286);
checkClosestAirport(std::string("EDDF"));
// For some reason the test code places this out by 1300m.
// Manual verification indicates that the placement and above lat/lon are
// correct.
checkPosition(parkingPosition, 2000.0);
}
void PosInitTests::testAirportAndAvailableParkingStartup()
{
{
Options* opts = Options::sharedInstance();
opts->setShouldLoadDefaultConfig(false);
const char* args[] = {"dummypath", "--airport=EDDF", "--parkpos=AVAILABLE"};
opts->init(3, (char**) args, SGPath());
opts->processOptions();
}
CPPUNIT_ASSERT(fgGetBool("/sim/presets/airport-requested"));
CPPUNIT_ASSERT(! fgGetBool("/sim/presets/runway-requested"));
CPPUNIT_ASSERT(globals->get_props()->getStringValue("/sim/presets/parkpos") == std::string("AVAILABLE"));
initPosition();
std::cout << "Parking position" << globals->get_props()->getStringValue("/sim/presets/parkpos") << "\n";
checkClosestAirport(std::string("EDDF"));
// Anywhere around EDDF will do!
checkPosition(FGAirport::getByIdent("EDDF")->geod(), 10000.0);
}
void PosInitTests::testAirportAndMetarStartup()
@ -117,6 +252,285 @@ void PosInitTests::testAirportAndMetarStartup()
double dist = SGGeodesy::distanceM(globals->get_aircraft_position(),
FGAirport::getByIdent("LOWI")->geod());
CPPUNIT_ASSERT(dist < 10000);
///sim/atc/runway
CPPUNIT_ASSERT(globals->get_props()->getStringValue("sim/atc/runway") == std::string("26"));
}
void PosInitTests::testAirportRunwayOffsetGlideslopeStartup()
{
{
Options* opts = Options::sharedInstance();
opts->setShouldLoadDefaultConfig(false);
const char* args[] = {"dummypath", "--airport=EDDF", "--runway=25C", "--offset-distance=5", "--glideslope=3.5"};
opts->init(5, (char**) args, SGPath());
opts->processOptions();
}
CPPUNIT_ASSERT(fgGetBool("/sim/presets/airport-requested"));
CPPUNIT_ASSERT(fgGetBool("/sim/presets/runway-requested"));
CPPUNIT_ASSERT(globals->get_props()->getStringValue("/sim/presets/runway") == std::string("25C"));
CPPUNIT_ASSERT(globals->get_props()->getIntValue("/sim/presets/offset-distance-nm") == 5);
initPosition();
CPPUNIT_ASSERT(globals->get_props()->getStringValue("/sim/airport/closest-airport-id") == std::string("EDDF"));
double crs = FGAirport::getByIdent("EDDF")->getRunwayByIdent("25C")->headingDeg() -180.0;
SGGeod expectedPos = SGGeodesy::direct(FGAirport::getByIdent("EDDF")->getRunwayByIdent("25C")->geod(), crs, 5 * SG_NM_TO_METER);
double dist = SGGeodesy::distanceM(globals->get_aircraft_position(),
expectedPos);
CPPUNIT_ASSERT(dist < 500);
// Check altitude based on glideslope. 5nm = 30380ft. so altitude should be 2213ft.
CPPUNIT_ASSERT_DOUBLES_EQUAL_MESSAGE("/position/altitude-ft", globals->get_props()->getDoubleValue("/position/altitude-ft"), 2213.0, 50.0);
}
void PosInitTests::testAirportRunwayOffsetAltitudeStartup()
{
{
Options* opts = Options::sharedInstance();
opts->setShouldLoadDefaultConfig(false);
const char* args[] = {"dummypath", "--airport=EDDF", "--runway=25C", "--offset-distance=5", "--altitude=3000"};
opts->init(5, (char**) args, SGPath());
opts->processOptions();
}
CPPUNIT_ASSERT(fgGetBool("/sim/presets/airport-requested"));
CPPUNIT_ASSERT(fgGetBool("/sim/presets/runway-requested"));
CPPUNIT_ASSERT(globals->get_props()->getStringValue("/sim/presets/runway") == std::string("25C"));
CPPUNIT_ASSERT(globals->get_props()->getIntValue("/sim/presets/offset-distance-nm") == 5);
initPosition();
CPPUNIT_ASSERT(globals->get_props()->getStringValue("/sim/airport/closest-airport-id") == std::string("EDDF"));
double crs = FGAirport::getByIdent("EDDF")->getRunwayByIdent("25C")->headingDeg() -180.0;
SGGeod expectedPos = SGGeodesy::direct(FGAirport::getByIdent("EDDF")->getRunwayByIdent("25C")->geod(), crs, 5 * SG_NM_TO_METER);
double dist = SGGeodesy::distanceM(globals->get_aircraft_position(),
expectedPos);
CPPUNIT_ASSERT(dist < 500);
CPPUNIT_ASSERT_DOUBLES_EQUAL_MESSAGE("/position/altitude-ft", globals->get_props()->getDoubleValue("/position/altitude-ft"), 3000.0, 10.0);
}
void PosInitTests::testVOROnlyStartup()
{
{
Options* opts = Options::sharedInstance();
opts->setShouldLoadDefaultConfig(false);
const char* args[] = {"dummypath", "--vor=JFK", "--vor-frequency=115.9"};
opts->init(3, (char**) args, SGPath());
opts->processOptions();
}
CPPUNIT_ASSERT(! fgGetBool("/sim/presets/airport-requested"));
CPPUNIT_ASSERT(globals->get_props()->getStringValue("/sim/presets/vor-id") == std::string("JFK"));
initPosition();
FGNavList::TypeFilter filter(FGPositioned::Type::VOR);
const nav_list_type navlist = FGNavList::findByIdentAndFreq( "JFK", 0.0, &filter );
double dist = SGGeodesy::distanceM(globals->get_aircraft_position(),
navlist[0]->geod());
CPPUNIT_ASSERT(dist < 500);
}
void PosInitTests::testVOROffsetAltitudeHeadingStartup()
{
{
Options* opts = Options::sharedInstance();
opts->setShouldLoadDefaultConfig(false);
const char* args[] = {"dummypath", "--vor=JFK", "--offset-distance=5", "--vor-frequency=115.9", "--offset-azimuth=78", "--altitude=1000", "--heading=45", "--vc=250"};
opts->init(7, (char**) args, SGPath());
opts->processOptions();
}
CPPUNIT_ASSERT(! fgGetBool("/sim/presets/airport-requested"));
CPPUNIT_ASSERT(! fgGetBool("/sim/presets/runway-requested"));
CPPUNIT_ASSERT(globals->get_props()->getIntValue("/sim/presets/offset-distance-nm") == 5);
initPosition();
FGNavList::TypeFilter filter(FGPositioned::Type::VOR);
const nav_list_type navlist = FGNavList::findByIdentAndFreq( "JFK", 115.9, &filter );
double dist = SGGeodesy::distanceM(globals->get_aircraft_position(),
SGGeodesy::direct(navlist[0]->geod(), 180 + 78, 5 * SG_NM_TO_METER));
CPPUNIT_ASSERT(dist < 1000);
CPPUNIT_ASSERT_DOUBLES_EQUAL_MESSAGE("/position/altitude-ft", globals->get_props()->getDoubleValue("/position/altitude-ft"), 1000.0, 10.0);
CPPUNIT_ASSERT_DOUBLES_EQUAL_MESSAGE("/orientation/heading-deg incorrect", globals->get_props()->getDoubleValue("/orientation/heading-deg"), 45.0, 1.0);
}
void PosInitTests::testFixOnlyStartup()
{
{
Options* opts = Options::sharedInstance();
opts->setShouldLoadDefaultConfig(false);
const char* args[] = {"dummypath", "--fix=FOLER"};
opts->init(2, (char**) args, SGPath());
opts->processOptions();
}
CPPUNIT_ASSERT(! fgGetBool("/sim/presets/airport-requested"));
CPPUNIT_ASSERT(globals->get_props()->getStringValue("/sim/presets/fix") == std::string("FOLER"));
initPosition();
FGNavList::TypeFilter filter(FGPositioned::Type::FIX);
const nav_list_type navlist = FGNavList::findByIdentAndFreq( "FOLER", 0.0, &filter );
double dist = SGGeodesy::distanceM(globals->get_aircraft_position(),
navlist[0]->geod());
CPPUNIT_ASSERT(dist < 500);
}
void PosInitTests::testFixOffsetAltitudeHeadingStartup()
{
{
Options* opts = Options::sharedInstance();
opts->setShouldLoadDefaultConfig(false);
const char* args[] = {"dummypath", "--fix=FOLER", "--offset-distance=5", "--offset-azimuth=78", "--altitude=1000", "--heading=45", "--vc=250"};
opts->init(6, (char**) args, SGPath());
opts->processOptions();
}
CPPUNIT_ASSERT(! fgGetBool("/sim/presets/airport-requested"));
CPPUNIT_ASSERT(! fgGetBool("/sim/presets/runway-requested"));
CPPUNIT_ASSERT(globals->get_props()->getStringValue("/sim/presets/fix") == std::string("FOLER"));
CPPUNIT_ASSERT(globals->get_props()->getIntValue("/sim/presets/offset-distance-nm") == 5);
initPosition();
FGNavList::TypeFilter filter(FGPositioned::Type::FIX);
const nav_list_type navlist = FGNavList::findByIdentAndFreq( "FOLER", 0.0, &filter );
double dist = SGGeodesy::distanceM(globals->get_aircraft_position(),
SGGeodesy::direct(navlist[0]->geod(), 180 + 78, 5 * SG_NM_TO_METER));
CPPUNIT_ASSERT(dist < 1000);
CPPUNIT_ASSERT_DOUBLES_EQUAL_MESSAGE("/position/altitude-ft", globals->get_props()->getDoubleValue("/position/altitude-ft"), 1000.0, 10.0);
CPPUNIT_ASSERT_DOUBLES_EQUAL_MESSAGE("/orientation/heading-deg incorrect", globals->get_props()->getDoubleValue("/orientation/heading-deg"), 45.0, 1.0);
}
void PosInitTests::testNDBOnlyStartup()
{
{
Options* opts = Options::sharedInstance();
opts->setShouldLoadDefaultConfig(false);
const char* args[] = {"dummypath", "--ndb=HHI", "--ndb-frequency=373"};
opts->init(3, (char**) args, SGPath());
opts->processOptions();
}
CPPUNIT_ASSERT(! fgGetBool("/sim/presets/airport-requested"));
CPPUNIT_ASSERT(globals->get_props()->getStringValue("/sim/presets/ndb-id") == std::string("HHI"));
initPosition();
FGNavList::TypeFilter filter(FGPositioned::Type::NDB);
const nav_list_type navlist = FGNavList::findByIdentAndFreq( "HHI", 373, &filter );
double dist = SGGeodesy::distanceM(globals->get_aircraft_position(),
navlist[0]->geod());
CPPUNIT_ASSERT(dist < 500);
}
void PosInitTests::testNDBOffsetAltitudeHeadingStartup()
{
{
Options* opts = Options::sharedInstance();
opts->setShouldLoadDefaultConfig(false);
const char* args[] = {"dummypath", "--ndb=HHI", "--ndb-frequency=373", "--offset-distance=5", "--offset-azimuth=78", "--altitude=1000", "--heading=45", "--vc=250"};
opts->init(8, (char**) args, SGPath());
opts->processOptions();
}
CPPUNIT_ASSERT(! fgGetBool("/sim/presets/airport-requested"));
CPPUNIT_ASSERT(! fgGetBool("/sim/presets/runway-requested"));
CPPUNIT_ASSERT(globals->get_props()->getStringValue("/sim/presets/ndb-id") == std::string("HHI"));
//CPPUNIT_ASSERT(globals->get_props()->getIntValue("/sim/presets/offset-distance-nm") == 5);
initPosition();
FGNavList::TypeFilter filter(FGPositioned::Type::NDB);
const nav_list_type navlist = FGNavList::findByIdentAndFreq( "HHI", 373, &filter );
double dist = SGGeodesy::distanceM(globals->get_aircraft_position(),
SGGeodesy::direct(navlist[0]->geod(), 180 + 78, 5 * SG_NM_TO_METER));
std::cerr << "Navlist size : " << navlist.size() << " dist " << dist << "\n";
CPPUNIT_ASSERT(dist < 1000);
CPPUNIT_ASSERT_DOUBLES_EQUAL_MESSAGE("/position/altitude-ft", 1000.0, globals->get_props()->getDoubleValue("/position/altitude-ft"), 10.0);
CPPUNIT_ASSERT_DOUBLES_EQUAL_MESSAGE("/orientation/heading-deg incorrect", 45.0, globals->get_props()->getDoubleValue("/orientation/heading-deg"), 1.0);
}
void PosInitTests::testLatLonStartup()
{
{
Options* opts = Options::sharedInstance();
opts->setShouldLoadDefaultConfig(false);
const char* args[] = {"dummypath", "--lat=55.9", "--lon=-3.355", "--altitude=1000"};
opts->init(4, (char**) args, SGPath());
opts->processOptions();
}
CPPUNIT_ASSERT(! fgGetBool("/sim/presets/airport-requested"));
CPPUNIT_ASSERT(! fgGetBool("/sim/presets/runway-requested"));
initPosition();
SGGeod pos = SGGeod::fromDeg(-3.355, 55.9);
checkPosition(pos, 100.0);
checkAlt(1000.0);
}
void PosInitTests::testLatLonOffsetStartup()
{
{
Options* opts = Options::sharedInstance();
opts->setShouldLoadDefaultConfig(false);
const char* args[] = {"dummypath", "--lat=55.9", "--lon=-3.355", "--altitude=1000", "--offset-distance=5", "--offset-azimuth=90", "--heading=45"};
opts->init(7, (char**) args, SGPath());
opts->processOptions();
}
CPPUNIT_ASSERT(! fgGetBool("/sim/presets/airport-requested"));
CPPUNIT_ASSERT(! fgGetBool("/sim/presets/runway-requested"));
initPosition();
SGGeod pos = SGGeodesy::direct(SGGeod::fromDeg(-3.355, 55.9), 270, 5 * SG_NM_TO_METER);
checkPosition(pos, 1000.0);
checkAlt(1000.0);
checkHeading(45.0);
}
void PosInitTests::testCarrierStartup()
{
{
Options* opts = Options::sharedInstance();
opts->setShouldLoadDefaultConfig(false);
const char* args[] = {"dummypath", "--carrier=Nimitz"};
opts->init(2, (char**) args, SGPath());
opts->processOptions();
}
CPPUNIT_ASSERT(! fgGetBool("/sim/presets/airport-requested"));
initPosition();
checkPosition(SGGeod::fromDeg(-122.6, 37.8), 100.0);
checkOnGround();
}

View file

@ -24,6 +24,7 @@
#include <cppunit/extensions/HelperMacros.h>
#include <cppunit/TestFixture.h>
#include "Airports/airport.hxx"
// The unit tests of the FGNasalSys subsystem.
@ -31,9 +32,36 @@ class PosInitTests : public CppUnit::TestFixture
{
// Set up the test suite.
CPPUNIT_TEST_SUITE(PosInitTests);
// Airport-based tests
CPPUNIT_TEST(testAirportAltitudeOffsetStartup);
CPPUNIT_TEST(testAirportAndMetarStartup);
CPPUNIT_TEST(testAirportAndRunwayStartup);
CPPUNIT_TEST(testAirportAndAvailableParkingStartup);
CPPUNIT_TEST(testAirportAndParkingStartup);
CPPUNIT_TEST(testAirportOnlyStartup);
CPPUNIT_TEST(testAirportRunwayOffsetAltitudeStartup);
CPPUNIT_TEST(testAirportRunwayOffsetGlideslopeStartup);
CPPUNIT_TEST(testDefaultStartup);
// Navaid tests
CPPUNIT_TEST(testVOROnlyStartup);
CPPUNIT_TEST(testVOROffsetAltitudeHeadingStartup);
CPPUNIT_TEST(testFixOnlyStartup);
CPPUNIT_TEST(testFixOffsetAltitudeHeadingStartup);
CPPUNIT_TEST(testNDBOnlyStartup);
CPPUNIT_TEST(testNDBOffsetAltitudeHeadingStartup);
CPPUNIT_TEST(testLatLonStartup);
//CPPUNIT_TEST(testLatLonOffsetStartup); This is not yet supported.
// Carrier tests
// We are not able to test the carrier code thoroughly as it depends
// heavily on finalizePosition(), which requires that the carrier model
// itself be loaded into the scenegraph.
CPPUNIT_TEST(testCarrierStartup);
CPPUNIT_TEST_SUITE_END();
public:
@ -44,9 +72,41 @@ public:
void tearDown();
// The tests.
void testAirportAltitudeOffsetStartup();
void testAirportAndMetarStartup();
void testAirportAndAvailableParkingStartup();
void testAirportAndParkingStartup();
void testAirportAndRunwayStartup();
void testAirportOnlyStartup();
void testAirportRunwayOffsetAltitudeStartup();
void testAirportRunwayOffsetGlideslopeStartup();
void testDefaultStartup();
// Navaid tests
void testVOROnlyStartup();
void testVOROffsetAltitudeHeadingStartup();
void testFixOnlyStartup();
void testFixOffsetAltitudeHeadingStartup();
void testNDBOnlyStartup();
void testNDBOffsetAltitudeHeadingStartup();
//Lat Lon tests
void testLatLonStartup();
void testLatLonOffsetStartup();
//Carrier tests
void testCarrierStartup();
private:
// Helper functions for tests. Return void as they use CPPUNIT_ASSERT
void checkAlt(float value);
void checkHeading(float value);
void checkPosition(SGGeod expectedPos, float delta=1000.0);
void checkClosestAirport(std::string icao);
void checkStringProp(std::string property, std::string expected);
void checkRunway(std::string expected);
void checkOnGround();
void checkInAir();
};
#endif // _FG_POSINIT_UNIT_TESTS_HXX