fly/flightgear
1
0
Fork 0
Code Activity

src/Viewer/sview.cxx: minor improvements to Step view's tower views.

Browse source 
Move forward 1 metre in tower view look from, to slightly improve view of
ground near tower.

Removed incorrect attempt to move towards target in other tower views, that
didn't work.
This commit is contained in:
Julian Smith 2021-01-30 12:41:44 +00:00
parent c59d9e039d
commit 8672a60699
1 changed files with 13 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
src/Viewer/sview.cxx
View file

@ -1136,7 +1136,7 @@ struct SviewViewEyeTarget : SviewView
m_steps.m_name = std::string() + "legacy tower" + callsign_desc; m_steps.m_name = std::string() + "legacy tower" + callsign_desc;
if (!strcmp(config->getStringValue("view/type"), "lookat")) { if (!strcmp(config->getStringValue("view/type"), "lookat")) {
/* E.g. Tower view. */ /* E.g. Tower view or Tower view AGL. */
/* Add a step to move to centre of aircraft. target offsets appear /* Add a step to move to centre of aircraft. target offsets appear
to have reversed sign compared to what we require. */ to have reversed sign compared to what we require. */
@ -1172,12 +1172,11 @@ struct SviewViewEyeTarget : SviewView
} }
m_steps.add_step(new SviewStepFinalToTarget); m_steps.add_step(new SviewStepFinalToTarget);
/* Add a step that moves towards the target a little to avoid eye /* Would be nice to add a step that moves towards the
being inside the tower walls. target a little, like we do with Tower view look from. But
simply adding a SviewStepMove doesn't work because the
[At some point it might be good to make this movement not change preceding SviewStepFinalToTarget has finalised the view
the height too.] */ angle etc. */
m_steps.add_step(new SviewStepMove(-10, 0, 0));
} }
else { else {
/* E.g. Tower view look from. */ /* E.g. Tower view look from. */
@ -1189,8 +1188,13 @@ struct SviewViewEyeTarget : SviewView
globals->get_props()->getDoubleValue("sim/current-view/pitch-offset-deg"), globals->get_props()->getDoubleValue("sim/current-view/pitch-offset-deg"),
globals->get_props()->getDoubleValue("sim/current-view/roll-offset-deg") globals->get_props()->getDoubleValue("sim/current-view/roll-offset-deg")
)); ));
/* Move forward a little as though one was walking towards
m_steps.add_step(new SviewStepMove(-10, 0, 0)); the window inside the tower; this might improve view of
aircraft near the tower on the ground. Ideally each tower
would have a 'diameter' property, but for now we just use
a hard-coded value. Also it would be nice to make this
movement not change the height. */
m_steps.add_step(new SviewStepMove(1, 0, 0));
m_steps.add_step(new SviewStepFinal); m_steps.add_step(new SviewStepFinal);
} }