fly/flightgear
1
0
Fork 0
Code Activity

Fix some off-by-one errors in variants GUI

Browse source
This commit is contained in:
James Turner 2015-03-05 14:51:33 +00:00
parent 13d50853df
commit 7ca9fba4a8
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/GUI/QtLauncher.cxx
View file

@ -293,9 +293,9 @@ public:
quint32 variantIndex = m_activeVariant.at(index.row());
if (variantIndex) {
if (variantIndex < item->variants.count()) {
if (variantIndex <= item->variants.count()) {
// show the selected variant
item = item->variants.at(variantIndex);
item = item->variants.at(variantIndex - 1);
}
}
@ -424,7 +424,7 @@ public:
if (variantCount > 0) {
bool canLeft = (currentVariant > 0);
bool canRight = (currentVariant < (variantCount - 1));
bool canRight = (currentVariant < variantCount );
QRect leftArrowRect = leftCycleArrowRect(option.rect, index);
painter->fillRect(leftArrowRect, canLeft ? Qt::black : Qt::gray);
@ -486,7 +486,7 @@ public:
m_view->model()->setData(index, variantIndex - 1, AircraftVariantRole);
emit variantChanged(index);
return true;
} else if ((variantIndex < (variantCount - 1)) && rightCycleRect.contains(me->pos())) {
} else if ((variantIndex < variantCount) && rightCycleRect.contains(me->pos())) {
m_view->model()->setData(index, variantIndex + 1, AircraftVariantRole);
emit variantChanged(index);
return true;