fly/flightgear
1
0
Fork 0
Code Activity

Don't clone far camera; create a new one and initialize it from the near camera

Browse source 
The clone operation may be sharing things that shouldn't be shared.
This commit is contained in:
timoore 2008-12-30 09:32:53 +00:00 • committed by Tim Moore
parent d43e0b83f7
commit 60e8f14d5b
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/Main/CameraGroup.cxx
View file

@ -134,8 +134,11 @@ CameraInfo* CameraGroup::addCamera(unsigned flags, Camera* camera,
Camera* farCamera = 0;
if ((flags & (GUI | ORTHO)) == 0) {
farCamera = simgear::clone(camera);
farCamera = new Camera;
farCamera->setAllowEventFocus(camera->getAllowEventFocus());
farCamera->setGraphicsContext(camera->getGraphicsContext());
farCamera->setCullingMode(camera->getCullingMode());
farCamera->setInheritanceMask(camera->getInheritanceMask());
// Each camera's viewport is written when the window is
// resized; if the the viewport isn't copied here, it gets updated
// twice and ends up with the wrong value.