fly/flightgear
1
0
Fork 0
Code Activity

Rewrite FGScheduledFlight::processTimeString

Browse source 
Use modern-style parsing to tolerate different numbers of
digits in time strings.
This commit is contained in:
James Turner 2021-07-21 22:57:16 +01:00
parent e64f70bc72
commit 364be50967
1 changed files with 37 additions and 40 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
src/Traffic/SchedFlight.cxx
View file

@ -172,8 +172,7 @@ FGScheduledFlight:: ~FGScheduledFlight()
time_t FGScheduledFlight::processTimeString(const string& theTime)
{
int weekday;
int timeOffsetInDays;
int timeOffsetInDays = 0;
int targetHour;
int targetMinute;
int targetSecond;
@ -187,24 +186,23 @@ time_t FGScheduledFlight::processTimeString(const string& theTime)
// okay first split theTime string into
// weekday, hour, minute, second;
// Check if a week day is specified
if (timeCopy.find("/",0) != string::npos)
{
weekday = atoi(timeCopy.substr(0,1).c_str());
const auto daySeperatorPos = timeCopy.find("/", 0);
if (daySeperatorPos != string::npos) {
const int weekday = std::stoi(timeCopy.substr(0, daySeperatorPos));
timeOffsetInDays = weekday - currTimeDate->getGmt()->tm_wday;
timeCopy = timeCopy.substr(2,timeCopy.length());
timeCopy = theTime.substr(daySeperatorPos + 1);
}
else
{
timeOffsetInDays = 0;
}
// TODO: verify status of each token.
if (timeCopy.length() < 8) {
SG_LOG( SG_AI, SG_WARN, "Timestring too short. " << theTime << " Defaulted to now" );
const auto timeTokens = simgear::strutils::split(timeCopy, ":");
if (timeTokens.size() != 3) {
SG_LOG(SG_AI, SG_DEV_WARN, "FGScheduledFlight: Timestring too short. " << theTime << " Defaulted to now");
return currTimeDate->get_cur_time();
}
targetHour = atoi(timeCopy.substr(0,2).c_str());
targetMinute = atoi(timeCopy.substr(3,5).c_str());
targetSecond = atoi(timeCopy.substr(6,8).c_str());
targetHour = std::stoi(timeTokens.at(0));
targetMinute = std::stoi(timeTokens.at(1));
targetSecond = std::stoi(timeTokens.at(2));
targetTimeDate.tm_year = currTimeDate->getGmt()->tm_year;
targetTimeDate.tm_mon = currTimeDate->getGmt()->tm_mon;
targetTimeDate.tm_mday = currTimeDate->getGmt()->tm_mday;
@ -214,8 +212,7 @@ time_t FGScheduledFlight::processTimeString(const string& theTime)
time_t processedTime = sgTimeGetGMT(&targetTimeDate);
processedTime += timeOffsetInDays * 24 * 60 * 60;
if (processedTime < currTimeDate->get_cur_time())
{
if (processedTime < currTimeDate->get_cur_time()) {
processedTime += repeatPeriod;
}
//tm *temp = currTimeDate->getGmt();