fly/flightgear
1
0
Fork 0
Code Activity

#410: multiplay manager reporting errors

Browse source 
receive on a non-blocking socket may return 0, which does not indicate an
error - and does not mean "errno" was upated. So do not check "errno",
errors there belong to calls elsewhere...
Error message apparently triggered constantly with FG2.4.0 on Windows.
This commit is contained in:
ThorstenB 2011-08-18 22:36:44 +02:00
parent ae6623655c
commit 104507ad8b
1 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/MultiPlayer/multiplaymgr.cxx
View file

@ -849,16 +849,24 @@ FGMultiplayMgr::update(double dt)
// packet waiting to be processed.
//////////////////////////////////////////////////
simgear::IPAddress SenderAddress;
bytes = mSocket->recvfrom(msgBuf.Msg, sizeof(msgBuf.Msg), 0,
int RecvStatus = mSocket->recvfrom(msgBuf.Msg, sizeof(msgBuf.Msg), 0,
&SenderAddress);
//////////////////////////////////////////////////
// no Data received
//////////////////////////////////////////////////
if (bytes <= 0) {
if (RecvStatus == 0)
break;
// socket error reported?
if (RecvStatus < 0)
{
// errno isn't thread-safe - so only check its value when
// socket return status < 0 really indicates a failure.
if (errno != EAGAIN && errno != 0) // MSVC output "NoError" otherwise
perror("FGMultiplayMgr::MP_ProcessData");
break;
}
// status is positive: bytes received
bytes = (ssize_t) RecvStatus;
if (bytes <= static_cast<ssize_t>(sizeof(T_MsgHdr))) {
SG_LOG( SG_NETWORK, SG_DEBUG, "FGMultiplayMgr::MP_ProcessData - "
<< "received message with insufficient data" );