From 0376ab3f28ac290f235343d7d72d997fe47639c7 Mon Sep 17 00:00:00 2001
From: Torsten Dreyer <Torsten@t3r.de>
Date: Tue, 4 Nov 2014 22:21:44 +0100
Subject: [PATCH] Fix #1579: Handle special characters in html property browser

---
 src/Network/http/PropertyUriHandler.cxx | 32 ++++++++++++++++++++++---
 src/Network/http/httpd.cxx              |  4 ++--
 2 files changed, 31 insertions(+), 5 deletions(-)

diff --git a/src/Network/http/PropertyUriHandler.cxx b/src/Network/http/PropertyUriHandler.cxx
index c9ebda7d8..77e6df8e6 100644
--- a/src/Network/http/PropertyUriHandler.cxx
+++ b/src/Network/http/PropertyUriHandler.cxx
@@ -37,6 +37,32 @@ using std::vector;
 namespace flightgear {
 namespace http {
 
+// copied from http://stackoverflow.com/a/24315631
+static void ReplaceAll(std::string & str, const std::string & from, const std::string & to) 
+{
+    size_t start_pos = 0;
+    while((start_pos = str.find(from, start_pos)) != std::string::npos) {
+        str.replace(start_pos, from.length(), to);
+        start_pos += to.length(); // Handles case where 'to' is a substring of 'from'
+    }
+}
+
+static const std::string specialChars[][2] = {
+  { "&",  "&amp;" },
+  { "\"", "&quot;" },
+  { "'", "&#039;" },
+  { "<", "&lt;" },
+  { ">", "&gt;" },
+};
+
+static inline std::string htmlSpecialChars( const std::string & s )
+{
+  string reply = s;
+  for( size_t i = 0; i < sizeof(specialChars)/sizeof(specialChars[0]); ++i )
+    ReplaceAll( reply, specialChars[i][0], specialChars[i][1] );
+  return reply;
+}
+
 class DOMElement {
 public:
   virtual ~DOMElement() {}
@@ -201,7 +227,7 @@ static DOMElement * renderPropertyValueElement( SGPropertyNode_ptr node )
         root = new DOMNode( "input" );
         root->setAttribute( "type", "text" );
         root->setAttribute( "name", node->getDisplayName() );
-        root->setAttribute( "value", value );
+        root->setAttribute( "value", htmlSpecialChars(value) );
         root->setAttribute( "size", boost::lexical_cast<std::string>( len ) );
         root->setAttribute( "maxlength", "2047" );
     } else {
@@ -212,7 +238,7 @@ static DOMElement * renderPropertyValueElement( SGPropertyNode_ptr node )
         root->setAttribute( "cols", boost::lexical_cast<std::string>( cols ) );
         root->setAttribute( "rows", boost::lexical_cast<std::string>( rows ) );
         root->setAttribute( "maxlength", "2047" );
-        root->addChild( new DOMTextElement( value ) );
+        root->addChild( new DOMTextElement( htmlSpecialChars(value) ) );
     }
 
     return root;
@@ -397,7 +423,7 @@ bool PropertyUriHandler::handleGetRequest( const HTTPRequest & request, HTTPResp
 
     e->setAttribute( "id", "currentvalue" );
     e->addChild( new DOMTextElement( "Current Value: " ) );
-    e->addChild( new DOMTextElement( node->getStringValue() ) );
+    e->addChild( new DOMTextElement( htmlSpecialChars(node->getStringValue()) ) );
 
     DOMNode * form = new DOMNode("form");
     body->addChild( form );
diff --git a/src/Network/http/httpd.cxx b/src/Network/http/httpd.cxx
index 9d41b66f2..81f8c9aac 100644
--- a/src/Network/http/httpd.cxx
+++ b/src/Network/http/httpd.cxx
@@ -105,7 +105,7 @@ public:
     Method = NotNull(connection->request_method);
     Uri = urlDecode(NotNull(connection->uri));
     HttpVersion = NotNull(connection->http_version);
-    QueryString = urlDecode(NotNull(connection->query_string));
+    QueryString = NotNull(connection->query_string);
 
     remoteAddress = NotNull(connection->remote_ip);
     remotePort = connection->remote_port;
@@ -117,7 +117,7 @@ public:
     for (string_list::iterator it = pairs.begin(); it != pairs.end(); ++it) {
       string_list nvp = split(*it, "=");
       if (nvp.size() != 2) continue;
-      RequestVariables.insert(make_pair(nvp[0], nvp[1]));
+      RequestVariables.insert(make_pair(urlDecode(nvp[0]), urlDecode(nvp[1])));
     }
 
     for (int i = 0; i < connection->num_headers; i++)