fly/flightgear
1
0
Fork 0
Code Activity
flightgear/src/GUI/MessageBox.hxx

36 lines
753 B
C++
Raw Normal View History

Message box support. This allows us to display a platform-native dialog for problems which occur early in startup (before we can show a PUI/Canvas dialog). In particular this improves feedback where FG_HOME, FG_DATA or aircraft selection is wrong, all of which happen very early in startup.
2013-11-06 23:49:58 +00:00
#ifndef FG_GUI_MESSAGE_BOX_HXX
#define FG_GUI_MESSAGE_BOX_HXX
#include <string>
Rename fatalMessageBox() to fatalMessageBoxWithoutExit(), add exiting variant - Rename fatalMessageBox() to fatalMessageBoxWithoutExit(). This should prevent the kind of bug that prompted this set of changes: someone calling fatalMessageBox(), assuming the program would stop at that point, whereas in reality it did not. - Add new function fatalMessageBoxThenExit(). This is not vital of course, but allows one to spare one line here and there and to apply the DRY principle for such fatal exits. - Replace every existing call to fatalMessageBox() with one or the other of the two new functions. Improve formatting along the way. This fixes a few bugs of the kind explained above.
2017-04-09 16:38:38 +00:00
#include <cstdlib>
Message box support. This allows us to display a platform-native dialog for problems which occur early in startup (before we can show a PUI/Canvas dialog). In particular this improves feedback where FG_HOME, FG_DATA or aircraft selection is wrong, all of which happen very early in startup.
2013-11-06 23:49:58 +00:00
namespace flightgear
{
Make fatalMessageBox() end with std::abort() and declare it [[noreturn]] Many places calling fatalMessageBox() assume it doesn't return, so make it behave this way. See discussion around: https://sourceforge.net/p/flightgear/mailman/message/35766691/ for some context.
2017-04-08 11:49:55 +00:00
enum MessageBoxResult
Message box support. This allows us to display a platform-native dialog for problems which occur early in startup (before we can show a PUI/Canvas dialog). In particular this improves feedback where FG_HOME, FG_DATA or aircraft selection is wrong, all of which happen very early in startup.
2013-11-06 23:49:58 +00:00
{
MSG_BOX_OK,
MSG_BOX_YES,
MSG_BOX_NO
};
MessageBoxResult modalMessageBox(const std::string& caption,
const std::string& msg,
const std::string& moreText = std::string());
Rename fatalMessageBox() to fatalMessageBoxWithoutExit(), add exiting variant - Rename fatalMessageBox() to fatalMessageBoxWithoutExit(). This should prevent the kind of bug that prompted this set of changes: someone calling fatalMessageBox(), assuming the program would stop at that point, whereas in reality it did not. - Add new function fatalMessageBoxThenExit(). This is not vital of course, but allows one to spare one line here and there and to apply the DRY principle for such fatal exits. - Replace every existing call to fatalMessageBox() with one or the other of the two new functions. Improve formatting along the way. This fixes a few bugs of the kind explained above.
2017-04-09 16:38:38 +00:00
MessageBoxResult fatalMessageBoxWithoutExit(
const std::string& caption,
Message box support. This allows us to display a platform-native dialog for problems which occur early in startup (before we can show a PUI/Canvas dialog). In particular this improves feedback where FG_HOME, FG_DATA or aircraft selection is wrong, all of which happen very early in startup.
2013-11-06 23:49:58 +00:00
const std::string& msg,
const std::string& moreText = std::string());
Make fatalMessageBox() end with std::abort() and declare it [[noreturn]] Many places calling fatalMessageBox() assume it doesn't return, so make it behave this way. See discussion around: https://sourceforge.net/p/flightgear/mailman/message/35766691/ for some context.
2017-04-08 11:49:55 +00:00
Rename fatalMessageBox() to fatalMessageBoxWithoutExit(), add exiting variant - Rename fatalMessageBox() to fatalMessageBoxWithoutExit(). This should prevent the kind of bug that prompted this set of changes: someone calling fatalMessageBox(), assuming the program would stop at that point, whereas in reality it did not. - Add new function fatalMessageBoxThenExit(). This is not vital of course, but allows one to spare one line here and there and to apply the DRY principle for such fatal exits. - Replace every existing call to fatalMessageBox() with one or the other of the two new functions. Improve formatting along the way. This fixes a few bugs of the kind explained above.
2017-04-09 16:38:38 +00:00
[[noreturn]] void fatalMessageBoxThenExit(
const std::string& caption,
const std::string& msg,
const std::string& moreText = std::string(),
int exitStatus = EXIT_FAILURE);
Message box support. This allows us to display a platform-native dialog for problems which occur early in startup (before we can show a PUI/Canvas dialog). In particular this improves feedback where FG_HOME, FG_DATA or aircraft selection is wrong, all of which happen very early in startup.
2013-11-06 23:49:58 +00:00
} // of namespace flightgear
#endif // of FG_GUI_MESSAGE_BOX_HXX
Copy permalink