From eea0e1e51aa7458887db4e73a08b105ff8139587 Mon Sep 17 00:00:00 2001 From: Vladimir Jelovac Date: Mon, 15 Jun 2020 20:37:32 +0200 Subject: [PATCH 1/5] Ground services menu optimizations mentioned in #151 --- AircraftConfig/groundservices.xml | 532 +++++++++++++++++++++--------- AircraftConfig/main.xml | 144 -------- 2 files changed, 385 insertions(+), 291 deletions(-) diff --git a/AircraftConfig/groundservices.xml b/AircraftConfig/groundservices.xml index 48a25f1e..a6d7faf3 100644 --- a/AircraftConfig/groundservices.xml +++ b/AircraftConfig/groundservices.xml @@ -8,7 +8,7 @@ ground-services vbox - + hbox @@ -26,163 +26,159 @@ - + - + + + hbox + + + vbox + + hbox + + true + + + + + + true + + + + + + vbox + + hbox + + true + + + + + + true + + + + + + + hbox + + + vbox + + + left + + + /gear/gear[0]/wow + /gear/gear[1]/wow + /gear/gear[2]/wow + + + /services/chocks/nose + + dialog-apply + + true + + + + + left + + + /gear/gear[0]/wow + /gear/gear[1]/wow + /gear/gear[2]/wow + + + /services/chocks/left + + dialog-apply + + true + + + + + left + + + /gear/gear[0]/wow + /gear/gear[1]/wow + /gear/gear[2]/wow + + + /services/chocks/right + + dialog-apply + + true + + + + + vbox + + + + left + /services/stairs/l1 + + dialog-apply + + true + + + + + left + /services/stairs/l4 + + dialog-apply + + true + + + + + left + /services/stairs/cover + + dialog-apply + + true + + + + vbox - - - left - /services/deicing_truck/enable - - dialog-apply - - true - - - - - - - - - - - - - left - /services/catering/enable - - dialog-apply - - true - - - - - - - left - /services/baggage/enable - - dialog-apply - - true - - hbox - true - + true - - - - left - /services/stairs/l1 - - dialog-apply - - true - - - - - left - /services/stairs/l4 - - dialog-apply - - true - - - - - left - /services/stairs/cover - - dialog-apply - - true - - + + + + + hbox - - - true - - - - - - true - - - - - hbox /systems/apu/oil/allow-oil-consumption @@ -193,21 +189,263 @@ /systems/apu/oil/level-l 3.9 5.4 - true - + true + dialog-apply - + 10 200 - + %.1f litres /systems/apu/oil/level-l - true + true + + + + left + /controls/electrical/ground-cart + + property-assign + /controls/electrical/switches/ext-pwr + 0 + + + + + /controls/gear/brake-parking + /services/chocks/nose + /services/chocks/left + /services/chocks/right + + + /velocities/groundspeed-kt + 2 + + + + + dialog-apply + + true + + + + + left + /controls/pneumatic/switches/groundair + + property-toggle + /controls/pneumatic/switches/groundair + + + + + /controls/gear/brake-parking + /services/chocks/nose + /services/chocks/left + /services/chocks/right + + + /velocities/groundspeed-kt + 2 + + + + + dialog-apply + + true + + + + + left + /controls/hydraulic/hand-pump-yellow + + property-toggle + /controls/hydraulic/hand-pump-yellow + + + + + /controls/gear/brake-parking + /services/chocks/nose + /services/chocks/left + /services/chocks/right + + + /velocities/groundspeed-kt + 2 + + + /systems/electrical/bus/ac-2 + 115 + + + /controls/electrical/switches/ext-pwr + 0 + + + + + dialog-apply + + true + - + + + vbox + + + hbox + + true + + + + + + true + + + + + + left + /services/baggage/enable + + dialog-apply + + true + + + + vbox + + + hbox + + true + + + + + + true + + + + + + left + /services/catering/enable + + dialog-apply + + true + + + + + + hbox + + true + + + + + + true + + + + + + + hbox + + true + + + + + + true + + + + + + left + /services/deicing_truck/enable + + dialog-apply + + true + + + + + + diff --git a/AircraftConfig/main.xml b/AircraftConfig/main.xml index eeb97261..e99c51c3 100644 --- a/AircraftConfig/main.xml +++ b/AircraftConfig/main.xml @@ -220,150 +220,6 @@ - - - left - - - /gear/gear[0]/wow - /gear/gear[1]/wow - /gear/gear[2]/wow - - - /services/chocks/nose - - dialog-apply - - true - - - - - left - - - /gear/gear[0]/wow - /gear/gear[1]/wow - /gear/gear[2]/wow - - - /services/chocks/left - - dialog-apply - - true - - - - - left - - - /gear/gear[0]/wow - /gear/gear[1]/wow - /gear/gear[2]/wow - - - /services/chocks/right - - dialog-apply - - true - - - - - left - /controls/electrical/ground-cart - - property-assign - /controls/electrical/switches/ext-pwr - 0 - - - - - /controls/gear/brake-parking - /services/chocks/nose - /services/chocks/left - /services/chocks/right - - - /velocities/groundspeed-kt - 2 - - - - - dialog-apply - - true - - - - - left - /controls/pneumatic/switches/groundair - - property-toggle - /controls/pneumatic/switches/groundair - - - - - /controls/gear/brake-parking - /services/chocks/nose - /services/chocks/left - /services/chocks/right - - - /velocities/groundspeed-kt - 2 - - - - - dialog-apply - - true - - - - - left - /controls/hydraulic/hand-pump-yellow - - property-toggle - /controls/hydraulic/hand-pump-yellow - - - - - /controls/gear/brake-parking - /services/chocks/nose - /services/chocks/left - /services/chocks/right - - - /velocities/groundspeed-kt - 2 - - - /systems/electrical/bus/ac-2 - 115 - - - /controls/electrical/switches/ext-pwr - 0 - - - - - dialog-apply - - true - - From b9783e78c9baba01f57b6ba46ed83faa3717c44c Mon Sep 17 00:00:00 2001 From: Vladimir Jelovac Date: Mon, 15 Jun 2020 22:58:36 +0200 Subject: [PATCH 2/5] #151 Reordered some elements and switched to vertical layout due to semantics. --- AircraftConfig/groundservices.xml | 456 ++++++++++++++---------------- 1 file changed, 218 insertions(+), 238 deletions(-) diff --git a/AircraftConfig/groundservices.xml b/AircraftConfig/groundservices.xml index a6d7faf3..80109d8e 100644 --- a/AircraftConfig/groundservices.xml +++ b/AircraftConfig/groundservices.xml @@ -30,131 +30,71 @@ - hbox + vbox - vbox - - hbox - - true - - - - - - true - - + hbox + + true + + + + + + true + - - vbox - - hbox - - true - - - - - - true - - - - + + + left + + + /gear/gear[0]/wow + /gear/gear[1]/wow + /gear/gear[2]/wow + + + /services/chocks/nose + + dialog-apply + + true + - - hbox + + + left + + + /gear/gear[0]/wow + /gear/gear[1]/wow + /gear/gear[2]/wow + + + /services/chocks/left + + dialog-apply + + true + - - vbox - - - left - - - /gear/gear[0]/wow - /gear/gear[1]/wow - /gear/gear[2]/wow - - - /services/chocks/nose - - dialog-apply - - true - - - - - left - - - /gear/gear[0]/wow - /gear/gear[1]/wow - /gear/gear[2]/wow - - - /services/chocks/left - - dialog-apply - - true - - - - - left - - - /gear/gear[0]/wow - /gear/gear[1]/wow - /gear/gear[2]/wow - - - /services/chocks/right - - dialog-apply - - true - - - - - vbox - - - - left - /services/stairs/l1 - - dialog-apply - - true - - - - - left - /services/stairs/l4 - - dialog-apply - - true - - - - - left - /services/stairs/cover - - dialog-apply - - true - - + + + left + + + /gear/gear[0]/wow + /gear/gear[1]/wow + /gear/gear[2]/wow + + + /services/chocks/right + + dialog-apply + + true + @@ -302,6 +242,49 @@ vbox + + hbox + + true + + + + + + true + + + + + + left + /services/stairs/l1 + + dialog-apply + + true + + + + + left + /services/stairs/l4 + + dialog-apply + + true + + + + + left + /services/stairs/cover + + dialog-apply + + true + + hbox @@ -325,127 +308,124 @@ true + - vbox - - - hbox - - true - - - - - - true - - - - - - left - /services/catering/enable - - dialog-apply - - true - - - - - - hbox - - true - - - - - - true - - - - - - - hbox - - true - - - - - - true - - - - - - left - /services/deicing_truck/enable - - dialog-apply - - true - - - + hbox + + true + + + + + + true + + + + + left + /services/catering/enable + + dialog-apply + + true + + + + + + hbox + + true + + + + + + true + + + + + + + hbox + + true + + + + + + true + + + + + + left + /services/deicing_truck/enable + + dialog-apply + + true + + + From af32913f509eda3f707c62c4e3be5a5817946604 Mon Sep 17 00:00:00 2001 From: Vladimir Jelovac Date: Mon, 15 Jun 2020 23:33:45 +0200 Subject: [PATCH 3/5] #151 Merged main gear left and right chokes under a single checkbox. --- AircraftConfig/groundservices.xml | 94 +++++++++++++++---------------- 1 file changed, 46 insertions(+), 48 deletions(-) diff --git a/AircraftConfig/groundservices.xml b/AircraftConfig/groundservices.xml index 80109d8e..b517a4d1 100644 --- a/AircraftConfig/groundservices.xml +++ b/AircraftConfig/groundservices.xml @@ -45,56 +45,54 @@ - - - left - - - /gear/gear[0]/wow - /gear/gear[1]/wow - /gear/gear[2]/wow - - - /services/chocks/nose - - dialog-apply - - true - + + hbox - - - left - - - /gear/gear[0]/wow - /gear/gear[1]/wow - /gear/gear[2]/wow - - - /services/chocks/left - - dialog-apply - - true - + + vbox + + + left + + + /gear/gear[0]/wow + /gear/gear[1]/wow + /gear/gear[2]/wow + + + /services/chocks/nose + + dialog-apply + + true + + - - - left - - - /gear/gear[0]/wow - /gear/gear[1]/wow - /gear/gear[2]/wow - - - /services/chocks/right - - dialog-apply - - true - + + vbox + + + left + + + /gear/gear[0]/wow + /gear/gear[1]/wow + /gear/gear[2]/wow + + + + property-toggle + /services/chocks/left + + + property-toggle + /services/chocks/right + + true + + + + From 11e15172a7710031fa96202c087906fce32abda7 Mon Sep 17 00:00:00 2001 From: Vladimir Jelovac Date: Tue, 16 Jun 2020 19:14:19 +0200 Subject: [PATCH 4/5] #151 Merging front and main gear chocks under a single checkbox --- AircraftConfig/groundservices.xml | 70 +++++++++++-------------------- 1 file changed, 24 insertions(+), 46 deletions(-) diff --git a/AircraftConfig/groundservices.xml b/AircraftConfig/groundservices.xml index b517a4d1..7e0d0079 100644 --- a/AircraftConfig/groundservices.xml +++ b/AircraftConfig/groundservices.xml @@ -46,52 +46,31 @@ - hbox - - - vbox - - - left - - - /gear/gear[0]/wow - /gear/gear[1]/wow - /gear/gear[2]/wow - - + vbox + + + left + + + /gear/gear[0]/wow + /gear/gear[1]/wow + /gear/gear[2]/wow + + + + property-toggle + /services/chocks/left + + + property-toggle + /services/chocks/right + + + property-toggle /services/chocks/nose - - dialog-apply - - true - - - - - vbox - - - left - - - /gear/gear[0]/wow - /gear/gear[1]/wow - /gear/gear[2]/wow - - - - property-toggle - /services/chocks/left - - - property-toggle - /services/chocks/right - - true - - - + + true + @@ -306,7 +285,6 @@ true - hbox From 1380fc3a371fcbba1e0dfd8e503ed61738260351 Mon Sep 17 00:00:00 2001 From: Vladimir Jelovac Date: Tue, 16 Jun 2020 19:32:18 +0200 Subject: [PATCH 5/5] #151 Adding missing property in order to set the checkbox state, --- AircraftConfig/groundservices.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/AircraftConfig/groundservices.xml b/AircraftConfig/groundservices.xml index 7e0d0079..e1b3bde3 100644 --- a/AircraftConfig/groundservices.xml +++ b/AircraftConfig/groundservices.xml @@ -57,6 +57,7 @@ /gear/gear[2]/wow + /services/chocks/nose property-toggle /services/chocks/left